adds some scripts to test failing compactions#295
Merged
keith-turner merged 6 commits intoapache:2.1from Aug 29, 2025
Merged
Conversation
dlmarion
reviewed
Jul 15, 2025
| System.out.println("Corrupted checksum value on key " + key); | ||
| } | ||
| } else { | ||
| System.out.println("No entry found after " + new String(startRow, UTF_8)); |
Contributor
There was a problem hiding this comment.
I wonder if this should be an exception instead of a println. It would be more obvious to the user running the command that it didn't work.
| # Format: a,b|a,b,c|c | ||
| test.ci.common.auths= | ||
| # Accumulo tserver properties to set when creating a table | ||
| test.ci.common.accumulo.server.props=\ |
Contributor
There was a problem hiding this comment.
Can we comment these lines instead of removing them? They serve as a good example on how to configure. When setting up a test cluster using the Terraform scripts, this repo gets cloned onto the test cluster for testing. Having these lines here as an example would mean that we don't have to look this up to do some testing.
Contributor
Author
There was a problem hiding this comment.
I reverted all the changes I made to the props file. All those changes were related to the specific testing I was doing
keith-turner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a few test scripts to explore how the code currently behaves w/ different kinds of compaction failures.
test/compation-failures/README.md gives an overview of what these test scripts offer